Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] UnusedNullCheck is not aware of Arrays.equals or Objects.equals #4907

Open
jsotuyod opened this issue Apr 1, 2024 · 0 comments
Open
Labels
a:false-negative PMD doesn't flag a problematic piece of code

Comments

@jsotuyod
Copy link
Member

jsotuyod commented Apr 1, 2024

Affects PMD Version:
7.0.0

Rule:

UnusedNullCheckInEquals

Description:

The rule is only checking against invocations to Object.equals.

Code Sample demonstrating the issue:

class NewEqualsHelpers {
    private Object[] multiple;
    private Object single;

    void test(NewEqualsHelpers other){
        if (other.multiple != null && java.util.Arrays.equals(other.multiple, multiple)) { } // should flag

        if (single != null && Objects.equals(single, other.single)) { } // should flag
    }
}

Expected outcome:

PMD should report a violation at lines 6 and 8.

Running PMD through: Any

@jsotuyod jsotuyod added the a:false-negative PMD doesn't flag a problematic piece of code label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:false-negative PMD doesn't flag a problematic piece of code
Projects
None yet
Development

No branches or pull requests

1 participant