Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom buttons in modal-footer? #30

Open
Andreas-Hjortland opened this issue Oct 2, 2015 · 2 comments
Open

Support custom buttons in modal-footer? #30

Andreas-Hjortland opened this issue Oct 2, 2015 · 2 comments

Comments

@Andreas-Hjortland
Copy link
Contributor

Would it be possible to add support for custom buttons in the <modal-footer> element? As of now you only support <button> and <au-button> which doesn't allow custom elements.

In my case I use a custom element <ladda> which gives the submit button a spinner when you click it.
Andreas-Hjortland pushed a commit to Andreas-Hjortland/aurelia-bs-modal that referenced this issue Oct 2, 2015
Merge branch 'plwalters#30-footer-custom-elts'
ee82762
@plwalters
Copy link
Owner

@Andreas-Hjortland Yes this is fine we can certainly switch to a more open content selector, PR accepted.

atsu85 pushed a commit to atsu85/aurelia-bs-modal that referenced this issue Oct 18, 2015
plwalters#30 - allow passing arbitrary content to modal-footer element
268da25
atsu85 pushed a commit to atsu85/aurelia-bs-modal that referenced this issue Oct 18, 2015
plwalters#30 - allow passing arbitrary content to modal-footer element
f17b4d7
@atsu85
Copy link

atsu85 commented Oct 18, 2015

to resolve this issue, please merge my pull request #33 and run gulp build to update dist folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atsu85 @Andreas-Hjortland @plwalters