Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large and small modals #10

Open
peebles opened this issue Jun 26, 2015 · 1 comment
Open

Large and small modals #10

peebles opened this issue Jun 26, 2015 · 1 comment

Comments

@peebles
Copy link

peebles commented Jun 26, 2015

I'd like to see some kind of support form modal-lg and modal-sm. Perhaps transferring any attached classes on to the div with class="modal-dialog". Or perhaps another binding:

<modal showing.bind="showing" size.bind="lg">

Perhaps even allowing the consumer of this plugin to supply their own "modal.html" template, for maximum flexibility.

@plwalters
Copy link
Owner

Supplying their own templates is 100% the goal of this project. The reason using content selectors is so powerful is that we want to provide the author the ability to provide override templates at will. As far as the various sizes right now odds are that we will continue to supply a default and allow the author to extend them.

Andreas-Hjortland pushed a commit to Andreas-Hjortland/aurelia-bs-modal that referenced this issue Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants