-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python API compatibility with custom Papermill engines #1122
Comments
this sounds like a regression error. we added @mehtamohit013: do you remember why we added this validation? looks like a bug. allowing people to use a custom papermill engine sounds reasonable |
@edublancas |
Thanks for looking into this! I tested with 0.22.3 and it works as expected (with executor_params changed to papermill_params) |
I'm trying to use the Ploomber Python API as a backend to a data workflow that uses a custom Papermill engine for running notebooks (to enable an additional feature of templating Markdown cells with jinja). The way this had worked with Papermill alone previously is passing the new engine's name to
papermill.execute_notebook()
under theengine_name
param. I tried doing this with Ploomber's NotebookRunner task, setting the executor to'papermill'
and including the custom engine name under the additionalexecutor_params
, but Ploomber seems not to support this, throwing the following error:An example of the way I'm setting up the NotebookRunner task is below:
Let me know if any more info would be helpful.
Is this something that would be a doable fix/enhancement in Ploomber's infrastructure?
The text was updated successfully, but these errors were encountered: