-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow per-package template imports #92
Labels
Comments
Another issue that isn't directly related to Twirl, but will help to test modified version with scoped imports - how to import modified version of Twirl into Play 2.4.6 project instead of built-in one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a multiple view sets (for example, one view set for website, and one view set for admin panel of it), and they need some common imports (custom template magic) and some imports specific to the set. Currently Twirl has no way to specify a scoped import, so there is a suggestion to introduce one.
Currently I have three ideas on how to implement it:
some.helpers._ @ some.views._
, so first part is import itself, and second part is a scope of that import. It will not break any existing imports, but it's a dirty way, I think.case class TemplateImport(import: String, scope: String)
and specify it either explicitly, or like SBT dependencies, provide an implicit conversion from string like"helpers._" % "views._"
. It possibly can break existing imports, because there is a chance that this implicit conversion will be out of scope inbuild.sbt
, but is a clean way.build.sbt
file (while retaining keytemplateImports
for compatibility, but making it deprecated). For example, there can be file like_imports.scala.html
that will hold imports in a Twirl usual format for that package and all descedants. Will not break anything if we keep old key, but it's the most hard way.I can implement this feature itself, but I think that it should be discussed before I implement it.
The text was updated successfully, but these errors were encountered: