-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve-async should support passing callback to specific functions such as .then #87
Comments
Another one might be
Granted, I could also see this being useful since it is odd use of |
Hey, guys. I was just about to report this myself. I made a PR twbs/bootstrap#32270 to add the plugin to our v4-dev branch and I think the setTimeout(done, 500) |
This is a known limitation at present. Please use ESLint disable comments for false positives for now. We need to design a user experience for what the rule options should look like, to allow users to allow whatever known false positives to be allowed. It would be ideal to make this as flexible as possible for most scenarios. Ideas welcome! |
Follow-up from #68.
The goal of this enhancement request is to support passing async callbacks to other functions, which the user expects will involve the async callback. For example, a user might pass an async callback to a promise's
.then
method.Since we don't have type information available, we probably don't want to have any defaults (not even assuming
.then
is for promises). So I would prefer making this a rule option where users could specify an ESQuery expression or similar. Not sure what the best user experience would be, though. Open to suggestions.The text was updated successfully, but these errors were encountered: