-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
83 add linting to GitHub test automation #84
Conversation
Hello, and thank you for contributing to the Upsun demo project! Setting up testsMost tests will run automatically when you open a pull request, while others require contributors with write access to enable. enable instructions tbd Failing testsIf your PR is failing, see the Running tests section of the README for troubleshooting details. Reviewing these changes locally:
|
@chadwcarlson - I'm going to pause on this one to reduce noise to the commit log. Feel free to update the code if you know what the issue is. Locally, the new linting and prettier commands work as expected. While running, the GitHub checks are (1) failing to use the Python packages installed by Once the |
@tylers-username Based on the error, I would guess we need to add activate the venv to use black. For example - |
@chadwcarlson - I was going to sneak some corrections into the I think the biggest step is implementing a 28 character limit on branch names and project titles for Upsun within these tests. |
@chadwcarlson I restored |
Closes #83 | Closes #85
Summarized Changes