Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

156 build performance improvement pnpm or bun #162

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

tylers-username
Copy link
Collaborator

This MR includes:

  • implementation of bun for performance improvements. We can discuss further if ppm is a better choice.
  • Hides build output for most commands to be easier on the eyes when customers are going through the onboarding experience
  • ⚠️ This includes changes from WIP: Ori requested updates #161

gilzow and others added 15 commits January 16, 2024 16:07
@radix-ui/react-tooltip 1.0.6 --> 1.0.7
@types/react 18.2.18 --> 18.2.48
@types/react-dom 18.2.7 —> 18.2.18
postcss 8.4.31 --> 8.4.33
react-code-blocks 0.1.4 --> 0.1.5
react-router-dom 6.16.0 --> 6.21.2
* blinker 1.6.3 --> 1.7.0
* certifi  2023.7.22 --> 2023.11.17
* charset-normalizer 3.3.1 --> 3.3.2
* idna 3.4 --> 3.6
* Jinja2 3.1.2 --> 3.1.3
* license-expression 30.1.1 --> 30.2.0
* packageurl-python 0.11.2 --> 0.13.4
* pip_audit 2.6.1 --> 2.7.0
* py-serializable 0.11.1 --> 0.17.1
* Pygments 2.16.1 --> 2.17.2
* rich 13.6.0 --> 13.7.0
* urllib3 2.0.7 --> 2.1.0
* pylint 3.0.2 --> 3.0.3
* black 23.3.0 --> 23.12.1
…edx-python-lib

cyclonedx-python-lib 4.2.3 depends on py-serializable<0.12.0 and >=0.11.1
There are no newer versions of cyclonedx-python-lib, and there is no version after 0.11.1 and before 0.12.0 of py-serializable so we're locked to 0.11.1.
@tylers-username tylers-username linked an issue Jan 17, 2024 that may be closed by this pull request
Copy link

Hello, and thank you for contributing to the Upsun demo project!

Setting up tests

Most tests will run automatically when you open a pull request, while others require contributors with write access to enable.
Until all tests pass, a pull request will not be merged.

enable instructions tbd

Failing tests

If your PR is failing, see the Running tests section of the README for troubleshooting details.

Reviewing these changes locally:

  1. Clone this repo

    git clone -b 156-build-performance-improvement-pnpm-or-bun [email protected]:platformsh/demo-project.git demo-test-156-build-performance-improvement-pnpm-or-bun && cd demo-test-156-build-performance-improvement-pnpm-or-bun
  2. Create a project on Upsun:

    upsun project:create --title "Demo Project test (pr-162/merge)" --default-branch 156-build-performance-improvement-pnpm-or-bun

    This command will set the local repository remote automatically, but you will need to specify the organization and region.

  3. Push to Upsun:

    upsun push

@tylers-username
Copy link
Collaborator Author

@gilzow @chadwcarlson - sorry, this probably should have been marked as a draft and mentioned in the description.

I don't know that bun is the best solution vs pnpm vs npm. I wanted to provide an environment for performance testing to save your team a bit of work.

@gilzow
Copy link
Collaborator

gilzow commented Jan 17, 2024

I mentioned this in the issue (#162 ) but I question switching the javascript package manager in use to something that isn't widely used in order to artificially speed up the demo builds.

@chadwcarlson chadwcarlson self-assigned this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build performance improvement: pnpm or bun
3 participants