Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore lost files #60

Closed
gilzow opened this issue Jul 3, 2023 · 0 comments · Fixed by #63
Closed

Restore lost files #60

gilzow opened this issue Jul 3, 2023 · 0 comments · Fixed by #63
Assignees
@gilzow
Labels
bug Something isn't working

Comments

@gilzow
Copy link
Contributor

gilzow commented Jul 3, 2023 •
edited
Loading

Describe the bug

PR #18 should not have been merged. seems template-builder included a bunch of things it shouldnt have.

When moving forward with the changes to template builder, I incorrectly assumed that PR-18 was correct and ready to merge, and was just waiting for workflow changes to be implemented. Once we discovered the issue, this repository was rolled back, but in doing so, lost the correct changes that were in PR #18. We need to re-add those back in.

These changes were a new header icon, a new svg logo and an update to the README

Include some logs

N/a

Reproducing

N/a

Expected behavior

n/a

Your environment

n/a

Screenshots

No response

Additional context

No response
@gilzow gilzow added the bug Something isn't working label Jul 3, 2023
@gilzow gilzow self-assigned this Jul 3, 2023
@gilzow gilzow mentioned this issue Jul 5, 2023
Merged
@Mupsi Mupsi closed this as completed in #63 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gilzow gilzow

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds missing svg image files that were lost in the reversion platformsh-templates/drupal9-govcms9
1 participant
@gilzow