-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
large file problems: uint32_t typo #3
Comments
There's something going on here regarding this issue. Not sure I fully understand though: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's an embarrassing typo in includes/dmg/dmg.h that prevents libdmg from reading large dmgs: the return value of readUInt64 should be uint64_t, not uint32_t.
A more cosmetic issue is that there's a line in hfs/hfslib.c that prints the total filesystem size, and it has some 32-bit values that need to be cast to 64-bit before multiplying.
After fixing those issues, libdmg seems to work fine at listing and extracting files from a 7 GB dmg.
The text was updated successfully, but these errors were encountered: