Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project status #135

Open
FriedrichFroebel opened this issue Aug 26, 2022 · 6 comments
Open

Project status #135

FriedrichFroebel opened this issue Aug 26, 2022 · 6 comments

Comments

@FriedrichFroebel
Copy link

It seems like the project does not involve any current activity. The last commit is from nearly 2.5 years ago, while there are quite some PRs and some folks already started forking the project to continue development.

There have been some commits to the master branch as well, where no corresponding release is available: v0.9.4...master. This includes disabling the warning about the devicedependent module being deprecated, although users of plain brother_ql cannot do much about it.

What is the current status of the project? Can we expect further development here?

@matmair
Copy link

matmair commented Dec 31, 2022

@FriedrichFroebel I have a fork with some of the PRs from here merged in. I need brother_ql as a dependency https://github.com/matmair/brother_ql-inventree

@FriedrichFroebel
Copy link
Author

@matmair I have already been aware of this fork due to one of your (misplaced) PRs against this upstream repository (which led to the creation of this issue to be honest). In the best case, I would like to see this upstream project to become active again, but given the current situation, this does not appear to be really likely. I personally considered working on a fork as well, but did not yet start with it - the first step would probably be to tackle #134 to ensure not to break anything first.

@matmair
Copy link

matmair commented Dec 31, 2022

@FriedrichFroebel there needs to be a lot of mocking done for #134 - if you want to make a PR to this repo I will gladly merge that into my fork too :-) .
I test the changes in my fork against the 3 printers I have before release, I do not think more can be done.

My hope that this project returns are small. I understand, life sometimes takes you into other ventures and nobody is owed anything here.

@FriedrichFroebel
Copy link
Author

Yes, I am aware that sufficient automated tests mean lots of work, but at least for me increases the trust for the actual code and when doing any changes/refactoring. For now, I do not have any direct plans for working on this due to other general workload. I might reconsider this later on, but as the code basically works for me at the moment, this does not have a high priority on my own to-do list.

@FriedrichFroebel
Copy link
Author

With the latest activity in https://github.com/matmair/brother_ql-inventree being in January, it does not seem like the fork is under active maintenance either (for example considering the Pillow filter changes which require modifications).

@matmair
Copy link

matmair commented Nov 5, 2023

@FriedrichFroebel we are actively using the project in hundreds of deployments now so I’m only changing things that need to change and only after careful testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants