Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade for pixi 7 #134

Open
brunocapdevila opened this issue Jan 20, 2023 · 2 comments
Open

upgrade for pixi 7 #134

brunocapdevila opened this issue Jan 20, 2023 · 2 comments

Comments

@brunocapdevila
Copy link

Hi!

I was testing out with some old flash animations.
We are currently using pixi 7.

I tried out forking the project to test if upgrading to pixi 7 was easy but I run into some dependency conflicts.

do you have any plans on upgrading ?

Thanks!

@brunocapdevila
Copy link
Author

even my npm install does not seem to work

npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^3.9.0" from the root project
npm ERR!   peer typescript@"^3.8.3" from @pixi/[email protected]
npm ERR!   node_modules/@pixi/eslint-config
npm ERR!     dev @pixi/eslint-config@"^1.0.1" from the root project
npm ERR!   4 more (compatfactory, rollup-plugin-ts, ts-clone-node, tsutils)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"4.6.x || 4.7.x || 4.8.x" from [email protected]
npm ERR! node_modules/typedoc
npm ERR!   dev typedoc@"^0.23.17" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/typescript
npm ERR!   peer typescript@"4.6.x || 4.7.x || 4.8.x" from [email protected]
npm ERR!   node_modules/typedoc
npm ERR!     dev typedoc@"^0.23.17" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/brunoc/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/brunoc/.npm/_logs/2023-01-20T16_36_16_030Z-debug-0.log```

@andrewstart
Copy link
Collaborator

We do, I have just been too busy to do it recently. For npm installs, it looks like a dependabot update missed the conflicting Typescript dependency when updating Typedoc. You'll need to change the typescript version to ^4.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants