Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If auto-detecting domains to verify, skip .herokuapp.com domain #44

Open
jalada opened this issue Feb 28, 2017 · 1 comment
Open

If auto-detecting domains to verify, skip .herokuapp.com domain #44

jalada opened this issue Feb 28, 2017 · 1 comment
Labels
enhancement

Comments

@jalada
Copy link
Collaborator

jalada commented Feb 28, 2017

It's pointless to verify it because Heroku will always use their own certificate, and it is a slight information leak to expose the name of the Heroku app in the certificate.
@concertiv concertiv mentioned this issue Mar 4, 2017
Closed
@jalada
Copy link
Collaborator Author

jalada commented Oct 7, 2020

This caught me out today; if you have only the herokuapp.com domain in the certificate, Heroku gives you a lousy 403 with no explanation when you try and upload the certificate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jalada