Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed domain wildcard issues #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed domain wildcard issues #45

wants to merge 2 commits into from

Conversation

kaspernj
Copy link

Closes #39

I have implemented two options to fix the wildcard domain issue:

  1. The Rake task chooses a domain that isn't a wildcard
  2. You can supply the domain you want used through an extra environment variable called HEROKU_APP_DOMAIN

@kaspernj
Copy link
Author

I can confirm this fixes my own wildcard issues, that I mentioned in the original issue.

@mrdomino mrdomino mentioned this pull request Mar 4, 2017
Open
@jalada
Copy link
Collaborator

jalada commented Mar 11, 2017

Thanks @kaspernj. For now can we split this in two and have one PR for fixing the wildcard issue, and another for introducing the HEROKU_APP_DOMAIN variable? Because the latter is part of a wider discussion around how we utilise ACME_DOMAIN (when provided).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wildcard domains on Heroku break renewal without an ACME_DOMAIN variable
2 participants
@kaspernj @jalada