Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs still reference fasttext.build_vocab sentences parameter #3501

Open
Jeff-Winchell opened this issue Oct 31, 2023 · 1 comment
Open

Docs still reference fasttext.build_vocab sentences parameter #3501

Jeff-Winchell opened this issue Oct 31, 2023 · 1 comment

Comments

@Jeff-Winchell
Copy link

Current version of Fasttext.build_vocab method has a first parameter with two possible names, neither of which is "sentences" despite that 2+ year-old (pre version 4) parameter name being listed on https://radimrehurek.com/gensim/models/fasttext.html

@gojomo
Copy link
Collaborator

gojomo commented Nov 5, 2023

Yep, see #3152. PRs that ensure the preferred, explicit 'corpus_iterable' & 'corpus_file' are used everywhere (while the 'sentences' doesn't break where it was working in any 4.x) – & docs match, showing 'sentences' as deprecated – would make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants