Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon color #215

Open
rayman89 opened this issue Sep 18, 2018 · 6 comments
Open

Icon color #215

rayman89 opened this issue Sep 18, 2018 · 6 comments

Comments

@rayman89
Copy link

Could you allow users to choose the color of the icon or at least give the black/white alternatives please?

@piroor
Copy link
Owner

piroor commented Oct 17, 2018

Sorry but this couldn't be done by my addon development policy. I decided to support both the latest ESR (it is 60 now) and regular release of Firefox, and SVG icons with flexible color is available only on Firefox 62 and later. After the next ESR (66 or 67?) is released, I can switch icons to flexible color version.

@rayman89
Copy link
Author

Cant there be a preference that a user can set to make the addon read an other icon file and just have 1 black and one white of the same icon on the addon xpi? Next firefox ESR version change is coming in like a year.

@piroor
Copy link
Owner

piroor commented Oct 18, 2018

Oh, I forgot such an idea! I've done it by b6fde5d so new icon will be available on the next release. Thanks!

@rayman89
Copy link
Author

Thank you I really appreciate your work.

@piroor
Copy link
Owner

piroor commented Oct 18, 2018

Oops, I forgot that you need to change svg.context-properties.content.enabled to true via about:config to apply theme colors...

@rayman89
Copy link
Author

rayman89 commented Oct 18, 2018

I still see it white with no option to change it to black or a darker color I have svg.context-properties.content.enabled set to true

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants