Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging multiple tabs to a new window caused all but one to irrecoverably disappear #202

Open
joshgold22 opened this issue Jun 11, 2018 · 5 comments

Comments

@joshgold22
Copy link

joshgold22 commented Jun 11, 2018

Short description

I selected a large number of tabs (scattered throughout a window with many more) and dragged from one of one of them intending to pull off to the side to a new window. It did create a new window, but only with the single tab I dragged from. Most criically: it closed all of the selected tabs on the original window.

I used this to select all of the "important" tabs on a window that had gotten too full. I meant to drag them to a window, copy urls of the less important ones just for the record and close those. Instead I lost all of the important in-progress work.

Steps to reproduce

I cannot reproduce this! But I wonder if it may relate to the trickiness with dragging. Often when I multi-select and then drag, if I don't get the timing right I end up losing the selection (which may have taken a long time to put together when there were many tabs to sort through.)

Still if that were the only problem, then I would be lose all my effort at selecting (frustrating but not so critical), but I should not lose the tabs: they would just be left behind in the old window to go through and select again.

When I try to replicate with smaller number of tabs, I either lose my selection (only the tab I try to drag is selected) or other times it works as expected.

I have both TST and Multiple Tab Handler enabled.

Expected result

  1. Drag tabs to a new window.
  2. Impossible to accidentally reset selection by dragging (I think It's fine to reset selection by clicking, but never if the mouse is dragged before releasing the click)

Actual result

Sometimes lost tabs and a new window with only one tab
Sometimes reset selection.
Sometimes correct behavior.

Environment

  • Platform (OS): OSX 10.12.6
  • Version of Firefox: 60.0.2
  • Version (or revision) of Multiple Tab Handler: 2.0.13

Additional notes:

  • If the dragging "ghost" showed whether it contains multiples, that would allow me to abort the drag when I see it is a single tab being dragged. (Ideally it could even include a count.)
  • Aborting a drag sometimes does not seem to work: I drag back to where it was (mouse back over the tab-bar of the old window) and I still get a new window. Not all the time, though.
@joshgold22
Copy link
Author

None of the missing tabs are shown under "recently closed tabs". I wonder if they are somehow hidden.

@piroor
Copy link
Owner

piroor commented Jul 12, 2018

Does this happen on a combination with Tree Style Tab? Or, MTH alone?

@joshgold22
Copy link
Author

joshgold22 commented Jul 12, 2018 via email

@piroor
Copy link
Owner

piroor commented Jul 13, 2018

Thanks. Then, the main operation to open a new window from dragged tabs is handled by TST instead of MTH. I couldn't reproduce this problem on my environment, so it may be fixed in the latest development build of TST: https://github.com/piroor/treestyletab/blob/master/README.md#development-builds

@joshgold22
Copy link
Author

Just updating to note that I haven't seen this again: I've only had it happen the one time that I reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants