Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tabs copied by default, even when only some are selected #33

Open
Gitoffthelawn opened this issue Jun 18, 2022 · 4 comments
Open

All tabs copied by default, even when only some are selected #33

Gitoffthelawn opened this issue Jun 18, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@Gitoffthelawn
Copy link

Short description

When the user has selected multiple tabs, the extension, by default, will copy all tabs (not just the selected ones).

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install the extension.
  3. Open 4+ tabs.
  4. Select 3 of the tabs.
  5. Use the extension to copy the tabs to the clipboard.

Expected result

Only copy the selected tabs, by default.

Actual result

All tabs are copied.

Environment

  • Platform (OS): Platform-independent issue
  • Version of Firefox: 101.0.1 (hey, it's a palindrome!)
  • Version (or revision) of extension: v1.4.5

Notes

Perhaps have an option in which the user can toggle this behaviour.

@piroor
Copy link
Owner

piroor commented Sep 9, 2022

I cannot reproduce this with:

  • Windows 10
  • Nightly 106.a1
  • Copy Selected Tabs to Clipboard v1.4.5

Steps I did:

  1. Start Nightly with clean profile.
  2. Install Copy Selected Tabs to Clipboard.
  3. Open five tabs.
  4. Click the first tab in the horizontal tab bar (Firefox's native tab bar).
  5. Ctrl-click two other tabs in the horizontal tab bar.
  6. Right-click on a highlighted tab.
  7. Choose "Copy to Clipboard" => URL.
  8. Go to a text editor and paste it. Three URLs are pasted as I expected.

@piroor piroor added the help wanted Extra attention is needed label Sep 9, 2022
@piroor
Copy link
Owner

piroor commented Sep 9, 2022

Is there any other condition? If there is any missing step or wrong step, please add more comments.

@Gitoffthelawn
Copy link
Author

Gitoffthelawn commented Sep 10, 2022

Thanks for your feedback.

The issue is still definitely present for me in FF v104.0.2 with extension v1.4.5.

I've added this to my schedule to look into this further. I'm hoping to have at least a half hour to spend on it this week soon.

Thanks again.

@Gitoffthelawn
Copy link
Author

I haven't forgotten about you! Just minimal free time. Still hoping to get to this very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants