Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passthrough to kryo.register and Kryo.setRegistrationRequired as alternative to Proguard #130

Open
wispborne opened this issue Jun 11, 2018 · 0 comments

Comments

@wispborne
Copy link

Enhancement request.

Paper uses Kryo's default creation of class identifiers, which simply uses the class's package name + name. This necessitates excluding serialized classes from Proguard, which is something the dev needs to keep in mind and remember to add to their proguard config when adding new classes to serialize.

Adding a passthrough to Kryo.setRegistrationRequired and Kryo.register for a Book would result in better performance, but more importantly it would help developers prevent bugs caused by forgetting to add a new class to proguard (which they might only realize after it was in production, in the worst case scenario), because the app would crash if Paper tried to touch a class that wasn't registered for serialization.

https://github.com/EsotericSoftware/kryo#registration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant