-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should list react-dom under peerDependencies #26
Comments
As a workaround, users can add the following lines to their .yarmrc.yml file 🙂 # react-step-progress-bar depends on react-transition-group, which lists react-dom as a peerDependency. This means that react-step-progress-bar should also list react-dom as a peerDependency, but it doesn't yet.
# This gives us an error while compiling, so we patch react-step-progress-bar to add react-dom as a peerDependency
#
# Bug report: https://github.com/pierreericgarcia/react-step-progress-bar/issues/26
packageExtensions:
react-step-progress-bar@*:
peerDependencies:
"react-dom": "*" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I believe
react
andreact-dom
should be listed as peer dependencies instead of dev dependencies inreact-step-progress-bar
'spackage.json
file:Without this, we have an issue:
Currently
react-step-progress-bar
depends onreact-transition-group
, which listsreact-dom
as a peer dependency. Sincereact-step-progress-bar
listsreact-dom
as a dev dependency instead of a peer dependency, we get an error when using the library with Yarn Berry's PnP (Plug and Play) feature turned on:The text was updated successfully, but these errors were encountered: