New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken typescript typings #104

Open

NaridaL opened this issue Jul 20, 2017 · 1 comment

Assignees

Labels

NaridaL commented Jul 20, 2017

The TS typings currently add stuff to the global scope, they should use something like http://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-function-d-ts.html so they work both in a browser env and when importing them as modules. Also add the typings to the "typings" field of the package.json so TS finds them when importing.

Owner

pid commented Jul 25, 2017

@stonio can you take a look on it?

pid self-assigned this

pid added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment