Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicator contrast wrong in article with background color #643

Open
Kamik423 opened this issue Dec 11, 2024 · 1 comment
Open

Loading indicator contrast wrong in article with background color #643

Kamik423 opened this issue Dec 11, 2024 · 1 comment

Comments

@Kamik423
Copy link

In buttons, the progress spinner uses a white or gray background, depending on context. In Articles this does not work, making the readability poor in some cases.

<button aria-busy="true">Button: Contrast adjusted</button>
<button aria-busy="true" class="outline">Button: Contrast adjusted</button>
<article aria-busy="true">Article</article>
<button aria-busy="true" class="pico-background-azure">Button: Contrast adjusted</button>
<article aria-busy="true" class="pico-background-azure">Article: Contrast not adjusted</article>

screenshot

@Yohn
Copy link

Yohn commented Dec 13, 2024

Took me a few tries but I believe I found what you were talking about..

With a light background, and having class contrast on a button, the text within the button was white, but the loading icon was too dark to see.

Heres a Codepen with a fix for this. I'll update that in my fork as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants