-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text cut off in dropdown nav in Safari 18.2 beta #634
Comments
Does this happen in the latest non beta release? I also don't think we would be supporting beta releases since it's not an official release yet, and things will change before the official release. |
@Yohn it seems to be a new issue in recent beta, I just updated iPhone to latest RC release, the issue is the same. Very likely you should be able to see the same bug next week in the final release version. |
@alphatownsman Thanks for the update! I just saw the iOS update is expected on Monday, maybe Tuesday next week so I will update as soon as I see that come out and will look into what could be causing this issue. Its good to have the heads up about it though, so thanks for that. If you have any ideas or possible fixes before the official release that be awesome, but if not its ok. I should be able to find it when I see it. |
@alphatownsman 18.2 is available, I and I can confirm I see this error as well. I looked in to this the other day and have some theories why it could be happening. I'll try to get a fix for this tonight. |
Appears to be caused by this code: pico/scss/components/_nav.scss Lines 12 to 16 in 6dc6489
Quick fix is to disable it with this css: :where(nav li)::before {
float: none;
content: "";
} I'm not sure what that does to VoiceOver, but in my limited testing it fixed the text cutoff issue. |
@64bitint Thanks for pointing out what you found! That definitely helped come up with a solution for iOS. The main fix was to add After digging I've realized that the Lines 2444 to 2447 in 6dc6489
I found this article on VoiceOver and list-style-type:none that used the same content: "\200B"; line and it mentioned that VoiceOver effect users will not see the navigation list because of list-style-type:none;
At the end the article said:
So I put a space in the content value and fingers crossed this would ensure the VoiceOver effect users will still see the navigation. :where(nav li)::before {
float: none;
content: " ";
} To get `\200B` in the compiled CSS:@use "sass:string"; // must be at the top of the file
:where(nav li)::before {
float: none;
content: string.unquote('"\\200B"');
} |
Describe the issue
Upgrade macOS to 15.2 beta, current public beta 3 (24C5089c), Safari 18.2 (20620.1.16.11.6)
Open https://picocss.com/docs/dropdown#usage-with-nav in Safari
Reproduction URL
https://picocss.com/docs/dropdown#usage-with-nav
Environment
Example: OS, versions, browser details.
macOS 15.2 beta, current public beta 3 (24C5089c), Safari 18.2 (20620.1.16.11.6)
The text was updated successfully, but these errors were encountered: