Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotted line if tooltip is added #629

Open
Kugeleis opened this issue Nov 12, 2024 · 3 comments
Open

dotted line if tooltip is added #629

Kugeleis opened this issue Nov 12, 2024 · 3 comments

Comments

@Kugeleis
Copy link

Kugeleis commented Nov 12, 2024

Describe the issue

Current Behavior

        <ul>
            <li>
                <label data-tooltip="Toggle dark and light mode" for="theme-toggle" class="theme-toggle-label">{%
                    include 'flaticons/bright.svg' %}
                    <input name="terms" class="theme-toggle" id="theme-toggle" type="checkbox" role="switch"
                        checked />{%
                    include 'flaticons/moon.svg' %}
                </label>
            </li>
        </ul>

produces a dotted line below the element.
data-tooltip="Tooltip" within the <input> element destroys formatting completely.

Expected Behavior

Only tooltip added

@Yohn
Copy link

Yohn commented Nov 27, 2024

Are you using the newest version of Pico here? Cause

&:not(a, button, input) {
border-bottom: 1px dotted;
text-decoration: none;
cursor: help;
}
prevents the dotted line on inputs in the current release of Pico here.

@Kugeleis
Copy link
Author

Yes, I'm using the latest version (2.0.6). Following your hint I added style="border-bottom: none;" to the element locally as a patch.

@Yohn
Copy link

Yohn commented Nov 30, 2024

I was able to duplicate your issue, and found a fix which I included in my fork of PicoCSS.

The main change for your issue is to update that line I pointed out previously to the follow:
&:not(:has(a, button, input, [role="button"])):not(a, button, input, [role="button"]) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants