Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL not working with new "group" #591

Open
comatan96 opened this issue Aug 9, 2024 · 1 comment · May be fixed by #599
Open

RTL not working with new "group" #591

comatan96 opened this issue Aug 9, 2024 · 1 comment · May be fixed by #599

Comments

@comatan96
Copy link

Please search for duplicate or closed issues first.

Describe the issue

RTL not working with new "group"

Current Behavior

For example. search button with wrong orientation:
image

Expected Behavior

The search should be on the right and aligned

Reproduction URL

https://codepen.io/Matan-Cohen-the-decoder/pen/poXWzgz

Environment

Linux, latest pico, chrome Version 127.0.6533.72 (Official Build)
@drmason13
Copy link

I believe this is due to use of physical properties in places like this: https://github.com/picocss/pico/blob/main/scss%2Fcomponents%2F_group.scss#L27-L36

Instead of left/right/top/bottom it should be inline-start/end/block-start/end. Corners are also possible.

I will raise a PR to fix this specifically. It is worth investigating the CSS as a whole for other uses of physical properties.

@drmason13 drmason13 linked a pull request Aug 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Logical properties improve rtl support drmason13/pico
2 participants
@drmason13 @comatan96