-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request textDocument/codeAction failed #57
Comments
I wanted to try phpactor with the VSCode extension and I'm getting the exact same error. Running :
|
VS Code does this in some cases, where it sends a decimal instead of int in some messages. Can you enable message tracing and show me a few messages before the exception. To enable it, set |
Hm. When I look at it again, this should already have been fixed in vscode. @Gog0 can you paste the exception if it goes over |
@zobo thanks for your quick answer. I thought it was all broken but apparently it doesn't crash on every files, I was unlucky with the first file I opened with the extension installed. I set to verbose and here is the (long) output I get when I open the problematic file (I removed the code from the whole class that was printed in the output as it's a customer project) : I can't say it helps me understand the problem, but I'll investigate a bit more to try to figure out what's happening.
|
From what I understand, it looks like I get double values for "character" number when I have PHP Mess Detector errors. I disabled the PHPMD extension I use (https://github.com/sandhje/vscode-phpmd) and it seems that phpactor stopped crashing. Not sure why one extension has an effect on this one. |
Ah yes, the "diagnostics" data gets passed from different extension and sources back to phpactor and other extensions. So the problem is actually in phpmd. There are two things we could do: have phpactor protocol code handle int and decimal - altho this is a protocol violation - or submit a ticket to vscode so that that is filtered in the core... I'll try to find a task I already opened in vscode. |
I'm getting the below exception on a new install of phpactor and vscode-phpactor when I type a single char.
MacOS: 13.6
VSCode: 1.83
The text was updated successfully, but these errors were encountered: