Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for functionMap.php #124

Open
1 of 4 tasks
IanDelMar opened this issue Nov 1, 2023 · 1 comment
Open
1 of 4 tasks

Tests for functionMap.php #124

IanDelMar opened this issue Nov 1, 2023 · 1 comment

Comments

@IanDelMar
Copy link
Contributor

IanDelMar commented Nov 1, 2023 •
edited by szepeviktor
Loading

As the function map expands, we should incorporate some checks. I suggest:

  • Relocating the parameter name check outside the visitor.
  • Verifying whether types have already been added through other parts of the visitor.
  • Ensuring the uniqueness of map entries.
  • Checking for unmatched parentheses.
@szepeviktor
Copy link
Member

szepeviktor commented Nov 1, 2023 •
edited
Loading

Ensuring the uniqueness of map entries.

PHPStan does this with every array.
https://phpstan.org/r/e722f28d-3c0d-4077-8996-8819813abaad
Resolved in #126

@szepeviktor szepeviktor mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @IanDelMar