-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider Even More Accessible Markup Pattern? #25
Comments
The markup changes are relatively trivial with Gutenberg Deprecated Blocks. The bigger challenge is in dealing with styles that users have already written to override the plugin defaults. By changing the markup, I'll be breaking any styles users have put in place—they would need to make updates to their code to address this. Ideally I'd like to avoid making breaking changes to the plugin. Happy to hear any suggestions you may have in regards to dealing with this issue. |
Good to know about the Deprecated Blocks docs. I didn't know about those! I hear you on the old styles and definitely can see that being an issue. (Even I would have to do that!) I could imagine rolling this out over a few releases:
No idea if this sounds like too much work, but that's roughly how I would approach. Thanks for hearing me out! |
I noticed double focus on tab title when using headings, once on the heading(tabindex="0") and on "a" tag. Right now can use JS to remove the tabindex. |
@LukaszJaro I'm not sure what you mean by |
NVM, somehow my accordion titles were also links for my categories...FIXED. thanks. |
I'm all for accessibility but I'd have to update either CSS or JS on probably 15 websites if this changes. What are the issues with If it's necessary to make the change, perhaps inheriting the heading styles over the
|
I generally like the markup of this plugin which was one reason I chose to use it on a recent project. However, I think it could likely be even better if it used Scott O'hara's recommended markup:
That would use a real button as the interactive element (less likely to have weird issues) and also let the heading keep it's native role and appear in outlines consistently.
I have no idea what's involved in making a change like this given that the block is already live, but I'd love for it to be considered!
The text was updated successfully, but these errors were encountered: