Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies with cmd_spawn #129

Open
dgsiegel opened this issue Aug 6, 2022 · 4 comments
Open

Dependencies with cmd_spawn #129

dgsiegel opened this issue Aug 6, 2022 · 4 comments

Comments

@dgsiegel
Copy link

dgsiegel commented Aug 6, 2022

I do have a configuration like this:

menu_item :library  :Foobar  :cmd_spawn       :quiet:/mnt/onboard/.adds/foobar.sh
  chain_success :dbg_toast :Done

The documentation states "By default, each action only executes if the previous one was successful.". Even though it seems that while the foobar script was executed in background, the toast message pops up immediately. Is there a way to let the chain wait until the first script has finished?

I know there is cmd_output, however this script might take longer than 10 seconds on some occasions...

@NiLuJe
Copy link
Collaborator

NiLuJe commented Aug 6, 2022

IIRC, no, not with a spawn, you'll want to handle the toast inside your script via NickelDBus ;).

@dgsiegel
Copy link
Author

dgsiegel commented Aug 6, 2022

Alright! In that case would it be possible to increase the timeout limit to e.g. 30 seconds? Seems like it's an arbitrary value anyways? https://github.com/pgaskin/NickelMenu/blob/master/src/action_cc.cc#L849

@NiLuJe
Copy link
Collaborator

NiLuJe commented Aug 6, 2022

Not really, we can't block safely for (much) more than that without risking the wrath of Nickel's watchdog, which would just kill nickel.

@pgaskin
Copy link
Owner

pgaskin commented Aug 6, 2022

Yes, and also, async actions are planned at some point in the future... #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants