Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue highlighting on 4.31.19086 #119

Closed
DavidNSB opened this issue Jan 20, 2022 · 6 comments
Closed

Issue highlighting on 4.31.19086 #119

DavidNSB opened this issue Jan 20, 2022 · 6 comments
Assignees
@pgaskin
Labels
bug high-priority location new-firmware-change

Comments

@DavidNSB
Copy link

After installing the 4.31.19086 firmware, an attempt to hightlight a phrase, a popup "NickelMenu Could not find the required SelectionMenuView and SelectionMneuController symbols for adding selection menu items (this is a bug)" was displayed. After clicking OK 3 times, the highlight menu was displayed.
@pgaskin pgaskin self-assigned this Jan 20, 2022
@pgaskin
Copy link
Owner

pgaskin commented Jan 20, 2022

I will try and release a fix for this tonight.

@pgaskin pgaskin pinned this issue Jan 20, 2022
@pgaskin pgaskin mentioned this issue Jan 20, 2022
Closed
12 tasks
@shermp
Copy link
Collaborator

shermp commented Jan 21, 2022

@pgaskin do you want me to take a quick look at this once I've decompiled libnickel?

@pgaskin
Copy link
Owner

pgaskin commented Jan 21, 2022

Yes, if you want to.

@shermp
Copy link
Collaborator

shermp commented Jan 21, 2022

Ok, will do, just waiting for Ghidra to finish chugging away at this.

@shermp
Copy link
Collaborator

shermp commented Jan 21, 2022 •
edited
Loading

Looks like SelectionMenuController::lookupWeb() is gone.

Looks like it may have been replaced with SelectionMenuController::lookupGoogle() and SelectionMenuController::lookupBaidu()

@pgaskin
Copy link
Owner

pgaskin commented Jan 21, 2022

Fixed in v0.5.3.

@jackiew1 jackiew1 mentioned this issue Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgaskin pgaskin

Labels
bug high-priority location new-firmware-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgaskin @shermp @DavidNSB