Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider giving -D defines precedence over default flags #55

Open
thoughton opened this issue Apr 2, 2018 · 0 comments
Open

Consider giving -D defines precedence over default flags #55

thoughton opened this issue Apr 2, 2018 · 0 comments

Comments

@thoughton
Copy link

Hi,

I recently tried using --define CMAKE_BUILD_TYPE=Debug on the cget build command line for a simple local project/package, but discovered the resulting binary still had no debug symbols.

After investigation using the --verbose flag I realised that my custom define was propogating to the resulting cmake command line, the problem was that the default -DCMAKE_BUILD_TYPE=Release flag was also being added to the command line after my define and essentially replacing it.

Is it worth considering a change whereby the user's custom commandline defines are always added to the end of the resulting cmake command and thereby always taking precedence?

(This certainly seems like it'd fix my issue of not being able to enable Debug builds on my project, but I don't know if there'd be any other unwanted side-effects...?)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant