New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] material receiveShadows is not used #359

Open

dmnsgn opened this issue Jan 17, 2024 · 0 comments

Labels

high scope/ecs type/fix

Milestone

Member

dmnsgn commented Jan 17, 2024

In v3, we used to set shadowQuality to 0 if it wasn't but in v4 it should probably be flagDefinitions:

[["material", "receiveShadows"], "RECEIVE_SHADOWS"],
[["options", "shadowQuality"], "SHADOW_QUALITY", { type: "value", requires: "RECEIVE_SHADOWS" }],

To be tested.

dmnsgn added type/fix scope/ecs labels

dmnsgn added this to the 4.0.0 milestone

vorg added the high label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment