Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostProcessing cleanup #354

Open
9 tasks
vorg opened this issue Nov 8, 2023 · 1 comment
Open
9 tasks

PostProcessing cleanup #354

vorg opened this issue Nov 8, 2023 · 1 comment

Comments

@vorg
Copy link
Member

vorg commented Nov 8, 2023

To get rid of legacy use cases i propose we simplify postpro settings a bit:

  • remove encoding from camera (we no longer do post processing outside of render pipeline so linear output is not needed ATM)
  • move fStop to DOF (fstop impacts dof only)
  • move exposure to color correction (default to 1, camera exposure was used to compensate bright hdri that have exposure on their own now)
  • move tonemapping to color correction (default to ACES, this impact colors too much so should be done together with other color settings)
  • rename toneMap to toneMapping
  • fog should happen in the material or at least before DOF (and boom as it is already)

Needs thinking and check

Nice to have

  • move on to .cube lut postprocessing format instead of .png (check is it applied to linear or gamma colors?)

Some notes on tonemapping. Currently tonemapping can happen in postprocessing final (and not in blit), in blit (if not postprocessing) and in material shader (if output encoding is gamma and you draw to texture aka not blit to screen).

@vorg
Copy link
Member Author

vorg commented Jun 1, 2024

AgX testing images as EXR https://github.com/sobotka/Testing_Imagery and ThreeJS thread mrdoob/three.js#27366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant