Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] followOutput doesn't scroll to bottom #1092

Closed
biscuitWizard opened this issue May 25, 2024 · 2 comments
Closed

[BUG] followOutput doesn't scroll to bottom #1092

biscuitWizard opened this issue May 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@biscuitWizard
Copy link

Describe the bug

When followOutput={true} is defined, per the docs, every new 'Item' should cause the window to scroll to the bottom. I'm seeing two issues:

  1. Intermittently Virtuoso doesn't scroll at all (in the case of many items being added at the same time)
  2. Virtuoso only scrolls to the last index - 1

2 is the much bigger issue; it scrolls to exactly the second to last element.

Reproduction

Visible in https://github.com/Torchship/dome-client.js/tree/vite ; clone the vite branch

To Reproduce
Steps to reproduce the behavior:

  1. Type 'MSSP-REQUEST' into the input box
  2. Hit Enter
  3. Repeat steps 1 & 2 until the buffer overflows
  4. See scroll acts inconsistently

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome

Additional context
I've stripped down the formatting and code around Virtuoso to as close as the examples for 'chat like' programs as much as I possibly can.

@biscuitWizard biscuitWizard added the bug Something isn't working label May 25, 2024
@petyosi
Copy link
Owner

petyosi commented May 26, 2024

Reproduce the problem in a code sandbox without the irrelevant parts and external dependencies. I'm closing this, as usually people don't come back.

@petyosi petyosi closed this as completed May 26, 2024
@biscuitWizard
Copy link
Author

I can see why this bug keeps popping up and remaining unresolved if that's the attitude lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants