Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Resize columns to fit on screen automatically #60

Closed
ZenurikSD opened this issue Aug 17, 2024 · 5 comments
Closed

[Feature Request] Resize columns to fit on screen automatically #60

ZenurikSD opened this issue Aug 17, 2024 · 5 comments

Comments

@ZenurikSD
Copy link

ZenurikSD commented Aug 17, 2024

First of all, thank you so much for the script, it feels like the perfect way to have tiled windows.

It would be nice to have some way to resize the windows that appear on new columns to fit on the current view. Most of the time my columns are just slightly wider than half of the screen, so when a new one appears, they never fit together side by side by default, and a manual resize is needed.

I think having a toggleable setting to "make columns fit on screen" with a configurable amount of max columns would be ideal.

Or maybe making the "Equalize widths of visible columns" option more robust to detect windows that are not fully visible to count as well would be enough (although it might change its behavior too much).

Video_2024-08-17_12-32-22.mp4
@ZenurikSD ZenurikSD changed the title [Feature request] [Feature Request] Resize columns to fit on screen automatically Aug 17, 2024
@peterfajdiga
Copy link
Owner

One of the goals of Karousel is to leave the control of window widths entirely to the user. But I agree that sometimes when opening a new window, you want to keep all the existing ones on the screen as well.

I've added two keyboard shortcuts: columns-squeeze-left and columns-squeeze-right (coming in 0.10). Using columns-squeeze-left after opening a new window should result in what you're asking for.

@ZenurikSD
Copy link
Author

I just tested it and it works really well for what I needed, thanks!

@ZenurikSD
Copy link
Author

ZenurikSD commented Nov 3, 2024

Also, sorry for asking too much of you, but if possible, can you consider adding the reverse effect to "expand" the column back to out of screen?

I ask because once the columns are squeezed in, you need two steps to undo the action: (1) resize the new column so it goes off screen and (2) equalize the widths of visible columns.

It's a minor inconvenience though, so I understand if you don't think it's worth doing

@peterfajdiga
Copy link
Owner

It's a good idea. You can try using the column-width-increase shortcut, but you can't know if it will push the left or the right column off the screen. I'll think about adding directional versions of this shortcut.

@ZenurikSD
Copy link
Author

Thank you! I'm closing this since the main issue was resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants