Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX support #1

Open
ogencoglu opened this issue Jul 23, 2024 · 5 comments
Open

ONNX support #1

ogencoglu opened this issue Jul 23, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ogencoglu
Copy link

Does it support ONNX conversion for example through skl2onnx if it has scikit-learn compatibility?

@deadsoul44
Copy link
Contributor

Hello, the API follows a sklearn style API with predict, fit, etc. methods. But, we should implement PerpetualRegressor and PerpetualClassifier, by inheriting respective base sklearn classes.

From skl2onnx docs:
Any external converter can be registered to convert scikit-learn pipeline including models or transformers coming from external libraries.

Even if we do this, skl2onnx might not work because under the hood, we have a Rust based estimator.

Probably the best way to support this is to implement our own onnx converter instead of relying on skl2onnx.

For people who are using Perpetual as part of a sklearn pipeline, we should provide an external converter.

@ogencoglu
Copy link
Author

Thanks for the swift reply!

@deadsoul44 deadsoul44 added enhancement New feature or request good first issue Good for newcomers labels Jul 23, 2024
@ryanrbftp
Copy link

+1 - we also need this feature!

@ryanrbftp
Copy link

@ogencoglu @deadsoul44 - in the meantime is there any workaround to get an ONNX model saved down after fitting the model?

@deadsoul44
Copy link
Contributor

No workaround. This might take some time to implement. PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants