Percy builds pass even when percySnapshot() fails

[MarosPistej]

BUG

About

We encountered issue which was even worse as it was on auto-approve branch master. One cy.percySnapshot() command failed (unknown reason, and it happen only once) but we were surprised that cypress test pass without issue, we expected that there is some assertion that cy.percySnapshot() was successful but it looks like there isn't? Result was that there was missing snapshot which was auto-approved, so in next tests we got diff that we have new snapshot even we didn't add any.

[Robdel12]

Hey @MarosPistej! This is how the SDKs currently work on purpose. We're going to be adding a flag to the CLI for users to exit 1 if any build or snapshot errors occur in the near future.

[itsjwala]

++ @IanVS @benedfit @MarosPistej

we believe this issue is related to percy/percy-cypress#568.

we'll be fixing ^ the issue soon in the coming weeks. Your patience’s appreciated!

[itsjwala]

Hey folks!

The modified cypress SDK can be installed from this git repo by using this command:
npm i --save-dev https://github.com/BrowserStackCE/percy-cypress.git

What it looks like in the package.json file:
"@percy/cypress": "github:BrowserStackCE/percy-cypress"

we'll be merging this in the upstream post doing some regression.

[IanVS]

Thanks @itsjwala. Is this compatible with npx percy snapshot?

[itsjwala]

Hey, @IanVS I'm afraid it's not, the above workaround is specific to Percy cypress SDK. could you start a new thread and attach verbose logs so we can check?

[IanVS]

Thanks, I've created #1181.