New command for provisioning DB namespaces #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasika-chivate
temporarily deployed
to
new_commands_db_namespaces - Everest Release Branch PR #185
Render
Destroyed
rasika-chivate
temporarily deployed
to
new_commands_db_namespaces - Everest Release Branch PR #185
Render
Destroyed
rasika-chivate
temporarily deployed
to
new_commands_db_namespaces - Everest Release Branch PR #185
Render
Destroyed
rasika-chivate
temporarily deployed
to
new_commands_db_namespaces - Everest Release Branch PR #185
Render
Destroyed
|
|
||
| - This command deletes only the specified namespace, as long as it is managed by Percona Everest. | ||
|
|
||
| - Setting the `--keep-namespace` option will delete all operators in the namespace but will not remove the namespace itself. It will only remove the Percona Everest label. |
There was a problem hiding this comment.
Suggested change
| - Setting the `--keep-namespace` option will delete all operators in the namespace but will not remove the namespace itself. It will only remove the Percona Everest label. | |
| - Setting `--keep-namespace` deletes all resources within the namespace (e.g., operators, DatabaseClusters, BackupStorages) while preserving the namespace itself. Use this option to clean up the namespace without removing it. |
|
|
||
| `--operator.xtradb-cluster=<bool>` | ||
|
|
||
| `--take-ownership` - If the namespace exists, it will be part of Percona Everest. If it is set to false, Percona Everest will throw an error. |
There was a problem hiding this comment.
Suggested change
| `--take-ownership` - If the namespace exists, it will be part of Percona Everest. If it is set to false, Percona Everest will throw an error. | |
| `--take-ownership` - Allows Everest to manage an existing Kubernetes namespace by adding the necessary labels. Without this flag, Everest will attempt to create the namespace and throw an error if it already exists. Use this flag to take over an existing namespace. |
Comment on lines
+46
to
+47
| !!! note | ||
| The `everestctl install` command can provision a DB namespace. However, if you run this command again, an error will be thrown: `Everest is already installed.` |
There was a problem hiding this comment.
Suggested change
| !!! note | |
| The `everestctl install` command can provision a DB namespace. However, if you run this command again, an error will be thrown: `Everest is already installed.` | |
| !!! note | |
| The `everestctl install` command lets you create database namespaces during the initial installation. However, it cannot be rerun to add more database namespaces. To create additional database namespaces after installation, use the namespaces add command.` |
There was a problem hiding this comment.
I think we should move this note to the section above, i.e, Add new namespaces
There was a problem hiding this comment.
I agree, this and the 2 bullets below feel out of place
Comment on lines
+50
to
+52
| - To provision a DB namespace after installation, use the command `everestctl namespaces add`. | ||
|
|
||
| - You may choose to skip the DB namespace installation in the `everestctl install` command. |
There was a problem hiding this comment.
Suggested change
| - To provision a DB namespace after installation, use the command `everestctl namespaces add`. | |
| - You may choose to skip the DB namespace installation in the `everestctl install` command. | |
| - To provision a DB namespace after installation, use the command `everestctl namespaces add`. | |
| - You may choose to skip the DB namespace installation in the `everestctl install` command. | |
| - Removing operators with `update` is currently not supported. |
Comment on lines
+85
to
+89
|
|
||
|
|
||
|
|
||
|
|
||
|
|
recharte
reviewed
Dec 13, 2024
| ``` | ||
|
|
||
| ```sh | ||
| everestctl namespaces add development --operator.postgresql=false --kubeconfig /Users/rasikachivate/Downloads/Kubeconfig |
There was a problem hiding this comment.
Suggested change
| everestctl namespaces add development --operator.postgresql=false --kubeconfig /Users/rasikachivate/Downloads/Kubeconfig | |
| everestctl namespaces add development --operator.postgresql=false |
|
|
||
| ??? example "Example" | ||
| ```sh | ||
| everestctl namespaces add production --kubeconfig /Users/rasikachivate/Downloads/Kubeconfig |
There was a problem hiding this comment.
Suggested change
| everestctl namespaces add production --kubeconfig /Users/rasikachivate/Downloads/Kubeconfig | |
| everestctl namespaces add production |
|
|
||
| ## Update namespaces | ||
|
|
||
| You can run the following command to add more operators to the DB namespace. |
There was a problem hiding this comment.
Suggested change
| You can run the following command to add more operators to the DB namespace. | |
| You can run the following command to add more operators to an existing DB namespace. |
Comment on lines
+46
to
+47
| !!! note | ||
| The `everestctl install` command can provision a DB namespace. However, if you run this command again, an error will be thrown: `Everest is already installed.` |
There was a problem hiding this comment.
I agree, this and the 2 bullets below feel out of place
Comment on lines
+42
to
+56
| 1. `everestctl namespaces add development` | ||
|
|
||
| ??? example "Expected output" | ||
| ??? example "Expected output" | ||
| ```sh | ||
| ? Which operators do you want to install? PostgreSQL | ||
| ✓ Installing namespace 'development' | ||
| ``` | ||
|
|
||
| ```sh | ||
| ? Namespaces managed by Everest [comma separated] dev,testing | ||
| ? What operators do you want to install? MySQL, MongoDB | ||
| ``` | ||
| 2. `everestctl namespaces add production`. | ||
|
|
||
| 2. Rerun the `everestctl install` command to install the PostgreSQL operator in the production and staging namespaces. | ||
| ??? example "Expected output" | ||
| ```sh | ||
| ? Which operators do you want to install? MySQL, MongoDB | ||
| ✓ Installing namespace 'production' | ||
| ``` |
There was a problem hiding this comment.
Maybe we can switch the order of these 2 examples because in the description above we first mention production and then development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new commands for provisioning database namespaces.
For detailed information refer to:
https://perconadev.atlassian.net/browse/EVEREST-1673