You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for starters: thanks for the quick feedback loop in my other ticket/PRs :-)
While I was adjusting the PR according to your feedback, I noticed that it's not possible to simply use an unreleased version of this lib from Github.
There are basically two changes needed because the dist file is obviously missing from this repo (and gladly so, I really dislike compiled code in repositories):
With those changes in place I can point my package.json to my branch and just use it. It would be nice to be able to do this in general and not depend on a new npm release after a fix has been merged (or even just using an existing PR for the time being).
My proposal is to include this change in the repo and let your release script basically revert the change before uploading to npm.
The text was updated successfully, but these errors were encountered:
Hey Per,
for starters: thanks for the quick feedback loop in my other ticket/PRs :-)
While I was adjusting the PR according to your feedback, I noticed that it's not possible to simply use an unreleased version of this lib from Github.
There are basically two changes needed because the dist file is obviously missing from this repo (and gladly so, I really dislike compiled code in repositories):
With those changes in place I can point my package.json to my branch and just use it. It would be nice to be able to do this in general and not depend on a new npm release after a fix has been merged (or even just using an existing PR for the time being).
My proposal is to include this change in the repo and let your release script basically revert the change before uploading to npm.
The text was updated successfully, but these errors were encountered: