Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free Shipping error in Calculator #4

Open
marcosdsdba opened this issue May 8, 2019 · 0 comments
Open

Free Shipping error in Calculator #4

marcosdsdba opened this issue May 8, 2019 · 0 comments

Comments

@marcosdsdba
Copy link

marcosdsdba commented May 8, 2019 •
edited
Loading

Steps to reproduce

  1. Install Magento from develop branch.
  2. Magento 2.3.1
  3. Create Cart Price Rule
    Conditions
    Total Items Quantity equals or greater than 2

Action
Percent of product price discount
Discount Amount 0
Maximum Qty Discount is Applied To 0
Discount Qty Step (Buy X) 0
Apply to Shipping Amount YES
Discard subsequent rules YES

Expected result

  1. Free Shipping

Actual result

1.Negative value causes NAN,N

Error-freeshipping

In line 292 in Validator.php method getShippingAmountForDiscount() doesn't exists ?????

Another method not found is getBaseShippingAmountForDiscount();

See https://github.com/pepe1518/magento2/blob/master/vendor/magento/module-sales-rule/Model/Validator.php#L292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcosdsdba