-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PASE-2049 | Resolve ESLint errors #861
base: master
Are you sure you want to change the base?
Conversation
Deploy preview for pmc-larva ready! ✅ Preview Built with commit ec39aab. |
This reverts commit ea6639e.
🚨 Backstop Visual Regression Tests Failed: View the results for 3a2d37030f590bc47cafe71266fb317f73a3fcda.How to view and update regression tests
💍 When the results contain changes you want to retainRun the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it. |
…ses the window/environment and cascades into terrible things
🚨 Backstop Visual Regression Tests Failed: View the results for eab975adf19eed807dc44dccd78b3c540d8dc2ca.How to view and update regression tests
💍 When the results contain changes you want to retainRun the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it. |
…larva into feature/PASE-2049
…larva into feature/PASE-2049
Make sure you complete these items:
Unpublished
sectionnpm run prod
in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)prod
,lint
, anddev
scripts run as expected