Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: keeping_ Files can be a string type, filtering files through wildcards. #1017

Open
3 tasks done
tidys opened this issue Oct 26, 2023 · 0 comments
Open
3 tasks done
Assignees
Labels

Comments

@tidys
Copy link

tidys commented Oct 26, 2023

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your proposal

I feel like keeping_ Files can be a string type, like excude_ Like assets, filtering files through wildcards.

Describe the solution you'd like

Simply put, my requirement is not to delete certain files in Warehouse B during synchronization, such as github action, readme.md, and so on.

Describe alternatives you've considered

Currently, I have executed two actions

  • The first time was
Keep_ Files: true
Exclude_ Assets: '*. js, *. css'
By `excluding_ Assets` delete all hash files
  • Second time
Keep_ Files: true
Exclude_ Assets: ''

Keep the previous state and synchronize the hash file again, but no files will be deleted this time

This can achieve my goal twice, but it doesn't feel very good

Additional context

I want to synchronize a directory from warehouse A to warehouse B,

But I have my own github action in Warehouse B, and I don't want the github action file in Warehouse B to be deleted

So I used keep_ Files option.

But the file I synchronized to Warehouse B is a website, and the JS and CSS file names have hashes,

For example, index.hash.js,

If I use keep_ Files

This will cause a lot of index. hash.js files to appear in the files synchronized with Warehouse B,

Actually, all you need is an index. has.js.

Later on, I discovered that exclude_ Assets, after reading the relevant code, I found that deleting the relevant files after synchronizing them to warehouse B does not meet my needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants