-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect precondition and postcondition error messages #70
Comments
Ok. Now seeing this and trying this for myself I think pre- and post-conditions error messages should be their business, not that of the pipeline stage. Recall I wrote the pipeline stage class first, way before I wrote conditions, and then I expected these messages to come up when the precondition failed. I think Also, let's work more closely on the writing this time, so write to me here when you have concrete suggestions. Note: This change shouldn't break the API whatsoever; just re-word current You're welcome to tackle this yourself, if you want. I want to focus on current issues with pickling stages and pipelines. :) |
For pipeline stages provided by the
pdpipe.basic_stages
, supplying conditions to theprec
andpost
keyword arguments may not return the correct error messages.Example Code
The problem is there for
post
argument too.Expected Result
Error message indicates that the user-provided precondition check failed. Or more specifically, column
x
was not found in thedf
.Actual Result
Error message indicates that the precondition check failed because column
a
was not found in thedf
.Reason
In
PdPipelineStage
,_compound_prec
checks for both user's precondition and the subclass's precondition but only one type of error message is provided for both.Possible Fix
Check the user-provided precondition
_prec_arg
and the subclass-provided precondition_prec
separately and display differentFailedPreconditionError
for each of them.The text was updated successfully, but these errors were encountered: