-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have a parameter for the year needed #110
Comments
Yes this is a good idea, I will have to do an analysis of the file sizes involved since adding too many yearly map data sets may increase the package size beyond the limit that CRAN recommends (I think 5 MB for data). Currently the |
Thanks. The Connecticut one is the most pressing. Changes in Virginia can be worked around in the data, but there is no direct translation of data between old and new Connecticut counties.
Sent via the Samsung Galaxy S22 Ultra 5G, an AT&T 5G smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Paolo Di Lorenzo ***@***.***>
Sent: Friday, May 17, 2024 3:15:22 PM
To: pdil/usmap ***@***.***>
Cc: CIO Data ***@***.***>; Author ***@***.***>
Subject: Re: [pdil/usmap] Have a parameter for the year needed (Issue #110)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
CAUTION: External Sender
Yes this is a good idea, I will have to do an analysis of the file sizes involved since adding too many yearly map data sets may increase the package size beyond the limit that CRAN recommends (I think 5 MB for data). Currently the usmapdata files that usmap uses take up about 3 MB uncompressed (~1 MB compressed) so there is probably room to add a few more years but either way I will investigate further.
—
Reply to this email directly, view it on GitHub<#110 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AV63IT7CEUF4HSFU2YRLLVDZCZJMVAVCNFSM6AAAAABH4S5PK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGIZTAOBSGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
### Changes * Add ability to select map data year when calling `us_map()` * e.g. `us_map(map_year = 2023)` * Implement changes to map data update workflow and related scripts to support this change ### Notes * `us_map()` will automatically select the appropriate year if the provided `map_year` is not available in the package resolves #34 see also pdil/usmap#110 and pdil/usmap#111
I was mapping county-level data today using usmap and realized that my values for Connecticut were being rejected. I am using data from 2016-2020, so it still has the older Connecticut counties in it, but apparently plot_usmap() only recognizes the new counties (which have different FIPS codes than the previous one). Would it be possible to allow a year argument so that the appropriate geometries get included for older data? I imagine this may come in useful in other circumstances as well (such as the ever evolving city/county issue in Virginia).
Thanks.
The text was updated successfully, but these errors were encountered: