Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to user profile in markdown #87

Open
shreyas1599 opened this issue May 12, 2020 · 6 comments · May be fixed by #169
Open

Link to user profile in markdown #87

shreyas1599 opened this issue May 12, 2020 · 6 comments · May be fixed by #169

Comments

@shreyas1599
Copy link
Contributor

Consider comment_item.
I'm trying to add a link to the profile. For example, @shreyas1599 should link to my profile. I used a simple regex to do this:

body.replaceAllMapped(new RegExp(r"@[^\s]+"), (match) { return "[${match[0]}](https://github.com/${match[0] })";

A couple of questions:

  • Should I place this in markdown_view.dart or leave it in comment_item.dart itself?
  • Also in mardown_view.dart I see you've used a github prefix. For now, I could just push the relative path.
  • But in router.dart you've added a TODO: /github.
  • So should I try and replace all the existing github routes to use the prefix github or just push the relative path for now? Something like this:
    return Provider.of<ThemeModel>(context).push(context, "/${m['login']}");
  • I could first open a PR to change all the existing routes to use /github and then implement the above.

@pd4d10 I'd like your opinion on this. Thanks.
@pd4d10
Copy link
Owner

pd4d10 commented May 12, 2020

If the purpose is to replace @somebody with a link, it seems not enough to just tweak the onTapLink method.

We should add a plugin to flutter_markdown to identify the @somebody syntax, then turn it into a link.

@pd4d10
Copy link
Owner

pd4d10 commented May 12, 2020

But in router.dart you've added a TODO: /github.

Yeah, it is a legacy todo. We should open an issue for this: Add /github prefix to GitHub related screens, just like other platforms.

@pd4d10
Copy link
Owner

pd4d10 commented May 12, 2020 •
edited

body.replaceAllMapped(new RegExp(r"@[^\s]+"), (match) { return "[${match[0]}](https://github.com/${match[0] })";

Oh, I missed this replacement process. This might also work but it seems more common to write a plugin for flutter_markdown

@shreyas1599
Copy link
Contributor Author

shreyas1599 commented May 16, 2020 •
edited

Sorry, I don't exactly understand. I've never written one before. By plugin do you mean, I use flutter_markdown and create a package that identifies the @ symbol and converts it into a link? Can you give an example of writing a plugin for a package?

@pd4d10
Copy link
Owner

pd4d10 commented May 17, 2020

MarkdownBody has a property named extensionSet: https://pub.dev/documentation/flutter_markdown/latest/flutter_markdown/MarkdownBody-class.html

For examples see: https://pub.dev/packages/markdown#syntax-extensions

@pd4d10
Copy link
Owner

pd4d10 commented May 17, 2020

There is also a legacy issue related to this: Rendering <img> tag correctly. <img> seems to be frequently used.

@shreyas1599 shreyas1599 linked a pull request Jan 19, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: markdown user profile links shreyas1599/git-touch
2 participants
@pd4d10 @shreyas1599