Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #33

Open
pavdmyt opened this issue Apr 4, 2019 · 6 comments
Open

Windows support #33

pavdmyt opened this issue Apr 4, 2019 · 6 comments

Comments

@pavdmyt
Copy link
Owner

pavdmyt commented Apr 4, 2019

In continuation to discussion on windows support for yaspin started in #32

Minimum plan towards Windows support:

  • apply the patch for handling signals
  • use vistir/cursor module for cursor support
  • implement (or find the replacement for) termcolor features in Windows environment
  • unittests for all yaspin features under Windows
  • CI pipeline for tests under Windows
@techalchemy
Copy link

  • It is definitely possible to retain the current API using colorama, I preserved the API for use in vistir with a wrapper and some tweaks to the implementation, so it shouldn't be a problem at all

@pavdmyt
Copy link
Owner Author

pavdmyt commented Feb 26, 2021

Related: #24

@oz123
Copy link

oz123 commented Apr 23, 2022

pipenv is currently getting new wind. I am currently helping to maintain pipenv, and I would be happy if we could upstream pipenv`s patches to yaspin. Would we be able to do so? Is there any way we can help you with the adoption of these patches?
@pavdmyt @matteius

@pavdmyt
Copy link
Owner Author

pavdmyt commented Apr 25, 2022

Hi @oz123

What are these patches about? Generally, I'm open for the new PRs.

@oz123
Copy link

oz123 commented Apr 25, 2022

This are patches that fix colors in Windows.

@pavdmyt
Copy link
Owner Author

pavdmyt commented May 4, 2022

@oz123 yes, I'm open to improve Windows support. Feel free to submit PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants