Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to implement content sharing? #137

Open
lmtoo opened this issue Feb 24, 2020 · 6 comments
Open

Is there any plan to implement content sharing? #137

lmtoo opened this issue Feb 24, 2020 · 6 comments

Comments

@lmtoo
Copy link

lmtoo commented Feb 24, 2020

create a content link which can access by anonymous user,this link invalid by setting expiration time,or forever valid

@paulcwarren
Copy link
Owner

paulcwarren commented Feb 25, 2020

For sure @lmtoo. I try to develop Spring Content based on user feedback. That was definitely on my list of items that we could do but until now no one had asked for it.

So, do you need one-time only links? Or expiring links? Or both?

@lmtoo
Copy link
Author

lmtoo commented Feb 25, 2020

both

@juja0
Copy link
Contributor

juja0 commented Jul 25, 2021

This would be quite useful to have. I was about to implement this locally as a POC to see if it can be achieved but decided to see if someone had already attempted it and I stumbled upon this issue.

I however wasn't able to decide on whether or not spring-content should track all the relevant metadata for the shared content like TTL etc, or if it should be delegated to the underlying store's native sharing abilities if they exist (for example, the S3 presigned URL feature).

If you have any thoughts on this, do let me know. If we end up settling on an approach, I'd be willing to submit a PR if PRs are welcome.

@JeroenAdam
Copy link

JeroenAdam commented Aug 20, 2021

FYI, the ElasticSearch team created a 'link-rating' app which sort of does that with links instead of contant, a shareable link for each search result.
It is showcased, open-sourced & explained here https://www.youtube.com/watch?v=84t_jC3dr3E&t=36m25s

@paulcwarren
Copy link
Owner

@JeroenAdam thanks for the link. I will watch that.

@juja0 apologies for the tardy response times. I think both approaches are probably valid, depending on use case. But I like the fact that implementing it in the spring content/spring content rest layer means it would be easy to consume, security is all configured in one place and you are not exposing the underlying details of your implementation. Would love to see a PR if you managed to get something working.

@juja0
Copy link
Contributor

juja0 commented Aug 26, 2021

@paulcwarren no worries. I didn't get to work on this further due to change in priorities. I will be revisiting this in the coming months. I'll submit a PR once I have something working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants