Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Button - loading spinner hard to see #1289

Open
jschuler opened this issue Jan 2, 2024 · 1 comment
Open

Bug - Button - loading spinner hard to see #1289

jschuler opened this issue Jan 2, 2024 · 1 comment

Comments

@jschuler
Copy link

jschuler commented Jan 2, 2024

Describe the problem
When the button is both disabled and in loading state, the loading spinner is hard to see. See comparison PF4 and PF5.

How do you reproduce the problem?

<Button variant="secondary" isLoading isDisabled>Secondary</Button>

PF4
https://github.com/patternfly/patternfly-react/assets/869106/f27800b7-0dfd-4fdf-a4f2-71986f283251

PF5
https://github.com/patternfly/patternfly-react/assets/869106/90dbd1d7-78ef-402d-ab8d-5c1a3489211a

What is your environment?

  • OS: macOS
  • Browser: Firefox
  • Version: 115.6.0esr (64-bit)

What is your product and what release date are you targeting?
OCM

Any other information?

@tlabaj
Copy link

tlabaj commented Jan 25, 2024

cc @andrew-ronaldson @mcoker

@srambach srambach transferred this issue from patternfly/patternfly-react Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

No branches or pull requests

2 participants