Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine File Upload and File Upload Multiple into a single component #1223

Open
mcarrano opened this issue Dec 20, 2022 · 2 comments
Open

Combine File Upload and File Upload Multiple into a single component #1223

mcarrano opened this issue Dec 20, 2022 · 2 comments
Assignees
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience.
Milestone

Comments

@mcarrano
Copy link
Member

mcarrano commented Dec 20, 2022

Currently File Upload and File Upload - Multiple are separate components to address distinct use cases. A more usable solution would be to combine these into one component. File Upload Multiple supports all upload use cases excepting the ability to preview a text file. Let's look at this to see if this can be added to File Upload Multiple allowing us to deprecate the single File Upload component.

Use cases:

  • Upload a single text file and give users the option to edit.
  • Upload a single binary file (no preview)
  • Upload multiple binary files in a single operation (no preview)
  • Select file to upload either by browsing the file system or drag and drop.
@mcarrano mcarrano added this to the 2023.01 milestone Dec 20, 2022
@mcarrano
Copy link
Member Author

mcarrano commented Jan 3, 2023

@yichen1yu Thanks for taking this on. I suggest starting be using the multiple file upload as a base and thinking about how to incorporate a single file text preview as an option. @megan-hall worked on this previously and should be able to provide any addition background about earlier design decisions and/or Sketch files so you don't need to start from scratch. Let me know if you have questions.

@yichen1yu
Copy link
Contributor

Here is the final design flow https://www.sketch.com/s/333bbc45-e187-4e1a-8c4e-f122ceab05ed

@mcarrano mcarrano modified the milestones: 2023.01, On hold Feb 13, 2023
@mcarrano mcarrano added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience.
Projects
Status: Done
Development

No branches or pull requests

2 participants