Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterToolbar - migrate from ODH and document API #34

Open
nicolethoen opened this issue Oct 9, 2024 · 0 comments
Open

FilterToolbar - migrate from ODH and document API #34

nicolethoen opened this issue Oct 9, 2024 · 0 comments
Milestone

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Oct 9, 2024

The code for this component currently lives at https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/components/FilterToolbar.tsx

The API of the new component should match the API of the component in ODH.
We can improve a11y, right-to-left language support, replace deprecated components under the hood, or generally clean up the implementation, as long as the API works in ODH.

  • lift the component out of it’s location in the ODH repo and into a new component directory in the module/src directory. (I highly recommend looking at pre-existing components in that directory for hints about directory and file structure)
    • The props for the component, with props descriptions, will be an important part of the documentation of the component
  • add a directory for the component to the /module/patternfly-docs/content/examples directory to build out the documentation (in markdown) for the migrated component. (again the preexisting component docs should be helpful templates for you)
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 9, 2024
@nicolethoen nicolethoen moved this from Needs triage to Ready to assign in PatternFly Issues Oct 9, 2024
@nicolethoen nicolethoen added this to the 2024.Q4 milestone Oct 9, 2024
@nicolethoen nicolethoen moved this from Ready to assign to Backlog in PatternFly Issues Nov 19, 2024
@nicolethoen nicolethoen moved this from Backlog to Ready to assign in PatternFly Issues Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to assign
Development

No branches or pull requests

1 participant